Laurentvallet issue#1980 (qc in ShUp) #2420
Conversation
| // Has quality check passed ? | ||
| if (qualityResult.hasError()) { | ||
| if (qualityResult != null && !qualityResult.isEmpty() && qualityResult.hasError()) { | ||
| // TODO : Delete newly created Examination ? |
There was a problem hiding this comment.
I think deleting the exam would not fit to the frontend import workflow as the exam is created "independently"
There was a problem hiding this comment.
I was worried about the empty created exams if quality control is KO and the fact that the user may recreated a new exam each time he tries to reimport the data.
...rc/main/java/org/shanoir/ng/studycard/model/condition/StudyCardDICOMConditionOnDatasets.java
Show resolved
Hide resolved
| <version>3.2.2</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>*</groupId> |
There was a problem hiding this comment.
what does that mean ? I guess it doesn't exclude everything does it ?
There was a problem hiding this comment.
It excludes all dependencies from the dependency ms-datasets to avoid dependency loops
|
@LaurentPV as said in the chat, failing to check quality should not bypass it. It should result in stopping the import and prompting an explicit error message. |
|
Hi @LaurentPV I'm vey sorry I take so much time to review this but could you lease merge develop to your branch there are 2 conflicts that I don't know how to fix. |
There was a problem hiding this comment.
I have a bug when a study has no quality card, it blocks the import.
2024-11-12 11:35:17 ERROR [org.shanoir.uploader.action.ImportDialogOpener] [77] Cannot invoke "java.util.Collection.toArray()" because "c" is null
java.lang.NullPointerException: Cannot invoke "java.util.Collection.toArray()" because "c" is null
at java.base/java.util.ArrayList.addAll(ArrayList.java:752)
at org.shanoir.uploader.action.ImportDialogOpener.getAllQualityCards(ImportDialogOpener.java:349)
at org.shanoir.uploader.action.ImportDialogOpener.getStudiesWithStudyCards(ImportDialogOpener.java:119)
at org.shanoir.uploader.action.ImportDialogOpener.openImportDialog(ImportDialogOpener.java:60)
at org.shanoir.uploader.nominativeData.CurrentNominativeDataController$1.mouseClicked(CurrentNominativeDataController.java:108)
at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:278)
private List<QualityCard> getAllQualityCards(List<Study> studies) throws Exception {
List<QualityCard> qualityCards = new ArrayList<QualityCard>();
for (Iterator<Study> iterator = studies.iterator(); iterator.hasNext();) {
Study study = (Study) iterator.next();
qualityCards.addAll(shanoirUploaderServiceClient.findQualityCardsByStudyId(study.getId()));
}
return qualityCards;
}
|
Also I wonder what is the meaning of this field that shows only auto check quality cards : Does this mean you can't have several quality cards checks on imports ? I think the back checks every quality card that is set as auto-check. |
|
michaelkain
changed the title
|
to see by Laurent |
Allowing ShanoirUploader to execute quality-control check using datasets ms code before executing the import.
Check quality code externalized in a new QualityService class in datasets.
Same rules as quality check on server side.
Apply only if quality card is checkAtImport.
Returns qualityCardResult report if in error, warning or failed valid.
Update upload status in ERROR if quality check in error.